os/bluestore: Prealloc memory avoid realloc in list_collection. #18804
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
requested changes
Nov 8, 2017
src/os/bluestore/BlueStore.cc
Outdated
| @@ -7121,6 +7121,7 @@ int BlueStore::getattrs( | |||
|
|
|||
| int BlueStore::list_collections(vector<coll_t>& ls) | |||
| { | |||
| ls.reserve(coll_map.size()); | |||
| RWLock::RLocker l(coll_lock); | |||
There was a problem hiding this comment.
can you move this down a line under the coll_lock? It's not safe to call size() outside of the lock.
There was a problem hiding this comment.
alloc memory may need long time and i don't hope by coll_lock. And if size() increase is small conceptual event. We don't consider this.
majianpeng
force-pushed
the
bluestore-collection-prealloc
branch
from
cdeff9b
to
d3d04ab
Compare
|
update by your suggestion. |
Signed-off-by: Jianpeng Ma <jianpeng.ma@intel.com>
liewegas
approved these changes
Feb 2, 2018
|
the failures are either caused by #19117 or tracked by http://tracker.ceph.com/issues/9356 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jianpeng Ma jianpeng.ma@intel.com