pybind/rados: add rados_service_*() #18812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Never mind, saw the link to the other PR. |
jdurgin
reviewed
Nov 27, 2017
| """ | ||
| service = cstr(service, 'service') | ||
| daemon = cstr(daemon, 'daemon') | ||
| metadata_dict = '\0'.join(chain.from_iterable(metadata.items())) |
There was a problem hiding this comment.
do these dict inputs need a trailing '\0' added for the c call?
There was a problem hiding this comment.
i inspected the concat'ed string using gdb, it does have two trailing \0s.
(gdb) p/c (char[24])*metadata_dict
$12 = {118 'v', 101 'e', 114 'r', 115 's', 105 'i', 111 'o', 110 'n', 0 '\000', 51 '3', 46 '.', 49 '1', 52 '4', 0 '\000',
109 'm', 101 'e', 109 'm', 111 'o', 114 'r', 121 'y', 0 '\000', 52 '4', 50 '2', 0 '\000', 0 '\000'}
but you are right. we can not rely on this.
Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-pybind-rados-service-api
branch
from
3de693a
to
8316f32
Compare
|
@jdurgin fixed and repushed. |
jdurgin
approved these changes
Dec 4, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com