tool: misc cleanup of ceph-kvstore-tool #18815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
approved these changes
Nov 8, 2017
|
jenkins test this please |
tchaikov
reviewed
Nov 9, 2017
src/tools/ceph_kvstore_tool.cc
Outdated
| } | ||
| std::ofstream fs(argv[4]); | ||
| uint32_t crc = st.traverse(string(), true, &fs); | ||
| fs.close(); |
There was a problem hiding this comment.
"fix" is too vague for me. could you expand a little bit in the commit message? iiuc, you are passing a never used ostream to traverse(), why?
i see, argv[4] is the output arg.
also, fs will be closed when it's destroyed. i don't think this call is really necessary.
There was a problem hiding this comment.
thank you, kefu, updated!
tchaikov
approved these changes
Nov 9, 2017
…e file as expected "store-crc <path>" command did not save result to <path>, it didn't use <path> argument and alwayls passed a NULL to "st.traverse" function. now we will create file <path>, pass a *ofstream to "st.traverse" function. Fiexes: http://tracker.ceph.com/issues/22092 Signed-off-by: Chang Liu <liuchang0812@gmail.com>
Signed-off-by: Chang Liu <liuchang0812@gmail.com>
liuchang0812
force-pushed
the
wip-kv-store-crc
branch
from
0432b3e
to
1f1a6f1
Compare
tchaikov
requested changes
Nov 9, 2017
| usage(argv[0]); | ||
| return 1; | ||
| } | ||
| std::ofstream fs(argv[4]); |
There was a problem hiding this comment.
it should be argv[3]. as cmd is argv[2].
could you use nvm, seems we are using args[3] instead?argv everywhere else ...
There was a problem hiding this comment.
it should be argv[4].
➜ build git:(wip-kv-store-crc) ✗ ./bin/ceph-kvstore-tool bluestore-kv dev/osd2 store-crc t2.txt 2>/dev/null
store at 't2.txt' crc 4037852868
tchaikov
approved these changes
Nov 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
store-crc <path>command. this command did not do anything before.@tchaikov @liewegas would you mind taking a look? thanks