mon: clean up cluster logging on mon events #18822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This isn't even a change to the map, just something that got echoed every time a new mon was the leader. Signed-off-by: John Spray <john.spray@redhat.com>
liewegas
approved these changes
Nov 8, 2017
src/mon/Monitor.cc
Outdated
| std::stringstream msg; | ||
| msg << "mon." << name << " is new leader, mons "; | ||
| for (auto i = quorum.begin(); i != quorum.end();) { | ||
| derr << "rank: " << *i << dendl; |
There was a problem hiding this comment.
also, see Monitor::get_quorum_names()?
There was a problem hiding this comment.
Thanks, I had a feeling I was forgetting about a helper
|
Updated |
tchaikov
reviewed
Nov 9, 2017
| @@ -635,8 +635,8 @@ class Monitor : public Dispatcher, | |||
| return (class MgrStatMonitor*) paxos_service[PAXOS_MGRSTAT]; | |||
| } | |||
|
|
|||
| class MgrStatMonitor *healthmon() { | |||
| return (class MgrStatMonitor*) paxos_service[PAXOS_MGRSTAT]; | |||
| class HealthMonitor *healthmon() { | |||
There was a problem hiding this comment.
is this method used anywhere?
There was a problem hiding this comment.
it wasn't before, but it is now in Monitor::win_election
tchaikov
reviewed
Nov 10, 2017
src/mon/Monitor.cc
Outdated
| })); | ||
|
|
||
| } else { | ||
| dout(4) << __func__ << " healthmon is not proposing" << dendl; |
There was a problem hiding this comment.
@jcsp can we lower the debug level to, for example, 10?
There was a problem hiding this comment.
Done (actually removed this one and demoted the one above to 20, I don't think we need the logging on the non-waiting case.
These changes come from observing the output when killing a mon and watching the survivors form a new quorum. Fixes: http://tracker.ceph.com/issues/22082 Signed-off-by: John Spray <john.spray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/22082
This is several minor tweaks to make sure what comes out the cluster log is sane and readable when a mon goes down.