rgw: RGWEnv::set() takes std::string #18866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the beast frontend will either pass a string_ref or a string_view,
depending on the boost version. we can't overload RGWEnv::set() for
both, because a call to env.set("literal") would be ambiguous
both string_ref and string_view have a to_string() member function, so
RGWEnv::set() now takes a std::string by value and moves it into the
map. this involes a single string copy, whether we pass a temporary
std::string (in beast) or a const char* (in civetweb)
Fixes: http://tracker.ceph.com/issues/22101
Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
@cbodley |
wjwithagen
approved these changes
Nov 12, 2017
There was a problem hiding this comment.
LGTM
My Jenkins build is back to normal
See http://cephdev.digiware.nl:8180/jenkins/job/ceph-master/1432/display/redirect?page=changes
|
thanks @wjwithagen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes a compilation failure with boost version 1.64 or later
Fixes: http://tracker.ceph.com/issues/22101
the beast frontend will either pass a string_ref or a string_view, depending on the boost version. we can't overload RGWEnv::set() for both, because a call to env.set(const char*) would be ambiguous
both string_ref and string_view have a to_string() member function, so RGWEnv::set() now takes a std::string by value and moves it into the map. this involes a single string copy, whether we pass a temporary std::string (in beast) or a const char* (in civetweb)