Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw.iam: change '1' to '1ULL' in function print_actions #18900

Merged
merged 1 commit into from Nov 15, 2017

Conversation

Projects
None yet
4 participants
@qrGitHub
Copy link

commented Nov 13, 2017

  • IAM has 54 operations corresponding to 54 bits. 1 is a signed integer
  • which can cover 31 operations, so we need 1ULL here.

Signed-off-by: Bingyin Zhang zhangbingyin@cloudin.cn

Bingyin Zhang
rgw.iam: change '1' to '1ULL' in function print_actions
* IAM has 54 operations corresponding to 54 bits. 1 is a signed integer
* which can cover 31 operations, so we need 1ULL here.

Signed-off-by: Bingyin Zhang <zhangbingyin@cloudin.cn>

@cbodley cbodley requested a review from adamemerson Nov 13, 2017

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Nov 13, 2017

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2017

@qrGitHub could you please clean up your branch so it's just the single commit?

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Nov 14, 2017

need to be retested, untagged

@yuriw yuriw removed the wip-yuri-testing label Nov 14, 2017

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Nov 14, 2017

Ok.
The fork in my github account is not clean now. So would you please reject this commit, then I can clean up my fork and pull another request?

@qrGitHub qrGitHub force-pushed the qrGitHub:master branch from 7cd524c to cff5537 Nov 15, 2017

@qrGitHub

This comment has been minimized.

Copy link
Author

commented Nov 15, 2017

@cbodley My branch is clean now, sorry for the improper commits.

@cbodley cbodley merged commit 71a8f8d into ceph:master Nov 15, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.