Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rgw: cleanup unused parameters in RGWRados::copy_obj_data #18917

Merged
merged 1 commit into from Nov 17, 2017

Conversation

Projects
None yet
4 participants
@ZVampirEM77
Copy link
Contributor

commented Nov 14, 2017

src_obj, max_chunk_size, category and ptag are out of use in RGWRados::copy_obj_data.

Signed-off-by: Enming Zhang enming.zhang@umcloud.com

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2017

@cbodley please review this pr~ thank you~

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2017

Jenkins, retest this please.

@joscollin
Copy link
Member

left a comment

There are many unnecessary changes (unwanted characters and alignment changes). Please fix ?

@joscollin joscollin added the rgw label Nov 14, 2017

@ZVampirEM77 ZVampirEM77 force-pushed the ZVampirEM77:wip-em-copyobjdata-cleanup branch from bfdc28e to 1063cbc Nov 14, 2017

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2017

@joscollin thank you for your suggestion. But what do you mean about unwanted characters? I can not find any unwanted characters. And I think that alignment changes for aligning all parameters is OK. What do you think?

@ZVampirEM77 ZVampirEM77 force-pushed the ZVampirEM77:wip-em-copyobjdata-cleanup branch from 1063cbc to 3fe8eeb Nov 14, 2017

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 14, 2017

@cbodley @joscollin I have recommitted, please review again~ thank you~

@joscollin

This comment has been minimized.

Copy link
Member

commented Nov 15, 2017

@ZVampirEM77 Sorry for the wrong term. I was referring to those alignment changes.

What I meant was: It is good to align it properly. But at a later point of time, people cannot easily recognize what (or why) you have changed in those lines when they see your name shows up in the git history (for instance git blame). In contrast, if you had made a code change in those lines, it was totally fine to align it properly. So that is the reason I gave that comment yesterday. However, it is a nit. :-)

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 15, 2017

@joscollin your suggestion is appreciated, thank you~ I will fix those alignment changes later.

rgw: cleanup unused parameters in RGWRados::copy_obj_data
src_obj, max_chunk_size, category and ptag are out
of use in RGWRados::copy_obj_data.

Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>

@ZVampirEM77 ZVampirEM77 force-pushed the ZVampirEM77:wip-em-copyobjdata-cleanup branch from 3fe8eeb to 3cd8511 Nov 16, 2017

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2017

@joscollin I have fixed those unnecessary alignment changes, please review again~

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2017

Jenkins, retest this please.

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2017

Jenkins, retest this please.

@joscollin

This comment has been minimized.

Copy link
Member

commented Nov 16, 2017

@ZVampirEM77 The jenkins fix is in progress. #18964. Wait until it is finished and then do a jenkins rebuild.

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 16, 2017

@joscollin OK, thank you~

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Nov 16, 2017

@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2017

Jenkins, retest this please.

1 similar comment
@ZVampirEM77

This comment has been minimized.

Copy link
Contributor Author

commented Nov 17, 2017

Jenkins, retest this please.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2017

test this please

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2017

ready for merge

@yuriw yuriw merged commit f870729 into ceph:master Nov 17, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.