rgw: check read_op.read return value in RGWRados::copy_obj_data #18962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The return-value-type of RGWRados::Object::Read::read is int, and the return value of RGWRados::Object::Read::read is either the length of object data which has been read if everything is OK, or the error value which is negative value if something is wrong. If an negative error value is assigned to read_len which is an unsigned long long type, the read_len will be a very large value, which will cause an error during RGWPutObjProcessor processing. Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
amitkumar50
approved these changes
Nov 16, 2017
|
Jenkins, retest this please. |
|
Jenkins, retest this please. |
|
@cbodley ping~ |
cbodley
approved these changes
Nov 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The return-value-type of RGWRados::Object::Read::read is int, and
the return value of RGWRados::Object::Read::read is either the
length of object data which has been read if everything is OK,
or the error value which is a negative value if something is wrong.
If a negative error value is assigned to read_len whose value type is
unsigned long long, the read_len will be a very large value,
which will cause an error during RGWPutObjProcessor processing.
Signed-off-by: Enming Zhang enming.zhang@umcloud.com