Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udev: Fix typo in udev OSD rules file #18976

Merged
merged 1 commit into from Nov 18, 2017
Merged

Conversation

yahooguntu
Copy link
Contributor

The rule for lockbox partitions had an invalid UUID for the "change" action.

@liewegas liewegas changed the title Fix typo in udev OSD rules file udev: Fix typo in udev OSD rules file Nov 16, 2017
@tchaikov
Copy link
Contributor

could you add a "Signed-off-by" line at the end of your commit message? "git commit -s" will do the trick for you. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work

@tchaikov
Copy link
Contributor

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it's "udev: ". please note, the title of pull request is different from that of a commit.

The rule for lockbox partitions had an invalid UUID for the "change" action.

Signed-off-by: Mitch Birti <yahooguntu@gmail.com>
@tchaikov tchaikov merged commit 6515dbe into ceph:master Nov 18, 2017
@yahooguntu yahooguntu deleted the patch-1 branch November 18, 2017 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants