Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

udev: Fix typo in udev OSD rules file #18976

Merged
merged 1 commit into from Nov 18, 2017

Conversation

Projects
None yet
3 participants
@yahooguntu
Copy link
Contributor

commented Nov 16, 2017

The rule for lockbox partitions had an invalid UUID for the "change" action.

@liewegas liewegas added the build/ops label Nov 16, 2017

@liewegas liewegas changed the title Fix typo in udev OSD rules file udev: Fix typo in udev OSD rules file Nov 16, 2017

@liewegas liewegas added the needs-qa label Nov 16, 2017

@tchaikov tchaikov added the bug fix label Nov 17, 2017

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2017

could you add a "Signed-off-by" line at the end of your commit message? "git commit -s" will do the trick for you. see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#1-sign-your-work

@tchaikov

This comment has been minimized.

Copy link
Contributor

commented Nov 17, 2017

could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes, in this case, it's "udev: ". please note, the title of pull request is different from that of a commit.

udev: Fix typo in udev OSD rules file
The rule for lockbox partitions had an invalid UUID for the "change" action.

Signed-off-by: Mitch Birti <yahooguntu@gmail.com>

@yahooguntu yahooguntu force-pushed the yahooguntu:patch-1 branch from 7be51ec to 5154172 Nov 17, 2017

@tchaikov tchaikov merged commit 6515dbe into ceph:master Nov 18, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@yahooguntu yahooguntu deleted the yahooguntu:patch-1 branch Nov 18, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.