rbd-mirror: removed dedicated thread from image deleter #19000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
reviewed
Nov 18, 2017
|
|
||
| namespace { | ||
|
|
||
| const int EISPRM = 1000; |
There was a problem hiding this comment.
nit: I see this was in the original code too. Anyway do we need a special error code here? We do not check for it, and it may propagate to ImageReplayer, and I suppose cpp_strerror() will generate a strange log message. May be use EBUSY instead?
trociny
reviewed
Nov 18, 2017
src/tools/rbd_mirror/ImageDeleter.cc
Outdated
| "rbd_mirror_concurrent_image_deletions")), | ||
| m_failed_interval(g_ceph_context->_conf->get_val<double>( | ||
| "rbd_mirror_delete_retry_interval")), | ||
| m_lock("rbd::mirror::ImageDeleter::m_lock"), |
There was a problem hiding this comment.
nit: If we did not cache these config settings in member variables we could change them in runtime.
trociny
reviewed
Nov 18, 2017
| derr << "failed to close: " << cpp_strerror(r) << dendl; | ||
| finish(r); | ||
| return; | ||
| } |
There was a problem hiding this comment.
@dillaman need to delete m_image_ctx
|
@trociny thanks -- update pushed |
added 6 commits
November 21, 2017 09:17
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Fixes: http://tracker.ceph.com/issues/15322 Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
|
Fixed a race condition in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.