Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: only create sysctl file on linux #19029

Merged
merged 1 commit into from Nov 22, 2017
Merged

cmake: only create sysctl file on linux #19029

merged 1 commit into from Nov 22, 2017

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Nov 20, 2017 •
edited

and check 64bit platform by looking at sizeof(void*)

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov
cmake: only create sysctl file on linux
89a4818 
and check 64bit platform by using the sizeof(void*)

Signed-off-by: Kefu Chai <kchai@redhat.com>
ddiss
ddiss approved these changes Nov 20, 2017
View reviewed changes
Copy link
Contributor

@ddiss ddiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

@wjwithagen
Copy link
Contributor

wjwithagen commented Nov 20, 2017 •
edited by tchaikov

@tchaikov
In FreeBSD I need to set someting thru sysctl as well. Now I just do that manually.
But if you are tinkering with sysctl anyways:

/etc/sysctl.conf:
# Make the kernel release socket fast so they can be reused.
# On ceph nodes 3 sec is long enough, packet do not go around the world
net.inet.tcp.msl=3000

Otherwise I'll submit a patch in due time.

@tchaikov
Copy link
Contributor Author

Otherwise I'll submit a patch in due time.

please go ahead.

@wjwithagen
Copy link
Contributor

@tchaikov
Will do.

amitkumar50
amitkumar50 reviewed Nov 20, 2017
View reviewed changes
CMakeLists.txt
@@ -604,7 +604,9 @@ if(WITH_SYSTEMD)
add_subdirectory(systemd)
endif()

add_subdirectory(etc/sysctl)
if(LINUX)
add_subdirectory(etc/sysctl)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should'nt be /etc/sysctl

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, it's relative to the top of the source directory.

@tchaikov
Copy link
Contributor Author

http://pulpito.ceph.com/kchai-2017-11-21_16:17:37-rados-wip-kefu-testing-2017-11-21-1844-distro-basic-mira/

@tchaikov tchaikov merged commit 6d78100 into ceph:master Nov 22, 2017
@tchaikov tchaikov deleted the wip-cmake-sysctl-cleanup branch November 22, 2017 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddiss ddiss ddiss approved these changes

@amitkumar50 amitkumar50 amitkumar50 left review comments

@smithfarm smithfarm smithfarm approved these changes

Assignees
No one assigned
Labels
build/ops cleanup needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
5 participants
@tchaikov @wjwithagen @smithfarm @ddiss @amitkumar50