Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msg: resurrect support for !CEPH_FEATURE_MSG_AUTH #19044

Merged
merged 2 commits into from Nov 22, 2017
Merged

msg: resurrect support for !CEPH_FEATURE_MSG_AUTH #19044

merged 2 commits into from Nov 22, 2017

Conversation

idryomov
Copy link
Contributor

No description provided.

@idryomov
msg/async/AsyncConnection: resurrect support for !CEPH_FEATURE_MSG_AUTH
87b075d 
Revert CEPH_FEATURE_MSG_AUTH-related hunks of commit 83f7e39
("msg/async/AsyncConnection: remove legacy feature case handle"), which
removed code that handled !CEPH_FEATURE_MSG_AUTH footers.  It's needed
for kernels prior to 3.19, where cephx signatures aren't supported.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@idryomov
msg/simple/Pipe: resurrect support for !CEPH_FEATURE_MSG_AUTH
0789059 
Revert CEPH_FEATURE_MSG_AUTH-related hunks of commit 7ba4d53
("msg/simple/Pipe: remove legacy feature case handle"), which
removed code that handled !CEPH_FEATURE_MSG_AUTH footers.  It's needed
for kernels prior to 3.19, where cephx signatures aren't supported.

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
@yuyuyu101
Copy link
Member

because kernel client needs?

@idryomov
Copy link
Contributor Author

@yuyuyu101 Yes, as noted in the commit message.

@idryomov
Copy link
Contributor Author

Test run (covers both old and new kernels): http://pulpito.ceph.com/dis-2017-11-20_18:39:51-krbd:unmap-wip-resurrect-msg-auth-testing-basic-smithi/

@tchaikov
Copy link
Contributor

dropping from my test batch.

@idryomov
Copy link
Contributor Author

@tchaikov Looks like an existing bug -- reproduced on your
wip-kefu-testing-2017-11-21-1844 with this PR reverted (603eacea7771).

     0> 2017-11-22 17:10:30.934 7fa3d5af0700 -1 /build/ceph-13.0.0-3422-g603eace/src/msg/async/AsyncConnection.cc: In function 'void AsyncConnection::process()' thread 7fa3d5af0700 time 2017-11-22 17:10:30.936672
/build/ceph-13.0.0-3422-g603eace/src/msg/async/AsyncConnection.cc: 705: FAILED assert(0 == "old msgs despite reconnect_seq feature")

 ceph version 13.0.0-3422-g603eace (603eacea77714074209fe75bf162922b8c839890) mimic (dev)
 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x10e) [0x7fa3dbb77f0e]
 2: (AsyncConnection::process()+0x27d4) [0x7fa3dbe044a4]
 3: (EventCenter::process_events(int, std::chrono::duration<unsigned long, std::ratio<1l, 1000000000l> >*)+0x331) [0x7fa3dbc07821]
 4: (()+0xb6733e) [0x7fa3dbc0a33e]
 5: (()+0xb1a60) [0x7fa3d8f29a60]
 6: (()+0x8184) [0x7fa3d95a1184]
 7: (clone()+0x6d) [0x7fa3d8690ffd]
 NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this.

@idryomov idryomov merged commit 98eb044 into ceph:master Nov 22, 2017
@idryomov idryomov deleted the wip-resurrect-msg-auth branch November 22, 2017 17:43
@tchaikov
Copy link
Contributor

tchaikov commented Nov 23, 2017 •
edited

@idryomov could you attach the link to the test? or the steps how you reproduced this issue? or better off filing a ticket in tracker? i am afraid that it's a serious issue.

@tchaikov
Copy link
Contributor

@idryomov could you fill http://tracker.ceph.com/issues/22231 with more details?

@idryomov
Copy link
Contributor Author

@tchaikov Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuyuyu101 yuyuyu101 yuyuyu101 approved these changes

Assignees
No one assigned
Labels
bug-fix core needs-qa
Projects
None yet
Milestone
No milestone
3 participants
@idryomov @yuyuyu101 @tchaikov