luminous: rbd: abort in listing mapped nbd devices when running in a container #19051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some container scenarios, the file '/sys/block/nbd0/pid' in the container records the host pid of the process which opened the device, therefore the file '/proc/pid/cmdline' corresponding to the pid in the container does not exist, in that case, 'rbd-nbd list-mapped' will cause the following assertion failure, this patch fixes it. src/tools/rbd_nbd/rbd-nbd.cc: In function 'int get_mapped_info(int, Config*)' /src/tools/rbd_nbd/rbd-nbd.cc: 834: FAILED assert(ifs.is_open()) ceph version 13.0.0-1632-gf9cfe84 (f9cfe84) mimic (dev) 1: (ceph::__ceph_assert_fail(char const*, char const*, int, char const*)+0x102) [0x7fc6b1054ba2] 2: (()+0x15c58) [0x560cd4697c58] 3: (main()+0x9) [0x560cd46937f9] 4: (__libc_start_main()+0xf0) [0x7fc6b003f830] 5: (_start()+0x29) [0x560cd46938f9] NOTE: a copy of the executable, or `objdump -rdS <executable>` is needed to interpret this. Aborted (core dumped) Fixes: http://tracker.ceph.com/issues/22011 Signed-off-by: Li Wang <laurence.liwang@gmail.com> (cherry picked from commit 07d5b81)
In some container scenarios, the host may choose to map a specific nbd device, for example, /dev/nbd6 into the container, in that case, the nbd device available in the container is not numbered from 0. The current unused nbd device search function will return no result. This patch fixes it. Fixes: http://tracker.ceph.com/issues/22012 Signed-off-by: Li Wang <laurence.liwang@gmail.com> Reviewed-by: Yunchuan Wen <yunchuan.wen@kylin-cloud.com> (cherry picked from commit be0f958)
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/22185