bluestore/NVMEDevice: do not deference a dangling pointer #19067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* pass coremask_arg to the working thread by value. after 81249ab, get_val<>() returns a temporary variables instead of a reference to the variant held by config. so calling string::c_str(), and passing the returned `const char*` to a thread is not advisable. instead we should pass a string by value. since spdk_env_init() will copy the settings passed in by opt. it's safe even to destruct the coremask_arg afterward. * use ffsll() to find the LSB. it's not a bottleneck, but it's easier and simpler, and probably improves the readability. * refactor the NVMEManager::try_get() method: to define the variables when they are used for the first time. Signed-off-by: Kefu Chai <kchai@redhat.com>
|
@liu-chunmei could you help review it? |
tchaikov
changed the title
yuyuyu101
approved these changes
Nov 21, 2017
adamemerson
approved these changes
Nov 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
after 81249ab, get_val<>() returns a temporary variables instead of a
reference to the variant held by config. so calling string::c_str(), and
passing the returned
const char*to a thread is not advisable. insteadwe should pass a string by value. since spdk_env_init() will copy the
settings passed in by opt. it's safe even to destruct the coremask_arg
afterward.
and simpler, and probably improves the readability.
when they are used for the first time.
Signed-off-by: Kefu Chai kchai@redhat.com