Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/workunits/rbd: wait for status propagated only if daemon started #19082

Merged
merged 1 commit into from Nov 22, 2017

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Nov 21, 2017

Signed-off-by: Mykola Golub to.my.trociny@gmail.com

Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
@trociny
Copy link
Contributor Author

trociny commented Nov 21, 2017

Alternatively we could start cluster2 daemon before split-brain test

@dillaman
Copy link

Assuming this change would re-introduce a race on the local environment? If so and if possible, might be easier to just start the second daemon before the test case.

@trociny
Copy link
Contributor Author

trociny commented Nov 22, 2017

I believe the error "image is still primary within a remote cluster" is possible only when the second daemon is started? As I understand it is triggered when the tag owner is not ORPHAN_MIRROR_UUID.
It is set to ORPHAN_MIRROR_UUID by demote request and can be changed only if mirroring is started?

I assume we are testing a bit different cases when running rbd_mirror.sh with RBD_MIRROR_USE_RBD_MIRROR set (daemons are not stopped/started, theuthology case) and when it is not set. If we force the second daemon to start, the cases will became the same. There is good and bad things with this.

I am slightly in favor of my current version though.

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman dillaman merged commit 5afd86f into ceph:master Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants