rgw: drop useless includes in rgw_{main.cc, common.h} #19109
Conversation
Signed-off-by: Jiaying Ren <jiaying.ren@umcloud.com>
| #include <errno.h> | ||
| #include <signal.h> | ||
|
|
||
| extern "C" { |
There was a problem hiding this comment.
@mikulely is current build broken without this change?
There was a problem hiding this comment.
No. As I've touched around, just take this chance to make nm happy.
There was a problem hiding this comment.
@mikulely could you be more specific regarding to the nm happy thing?
There was a problem hiding this comment.
There was a problem hiding this comment.
@mikulely if you care about the exported symbols from radosgw (actually i wonder why), probably you should fix the CMakeLists.txt to avoid exporting them.
There was a problem hiding this comment.
@tchaikov Thx for minding. Just a trivial cleanup here, let's forget about it.
There was a problem hiding this comment.
i'd recommend do it right if we want to fix it even it's a cleanup.
|
@joscollin |
No description provided.