mon/PGMap: Fix %USED calculation bug. #19165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tchaikov mind take a look? |
tchaikov
approved these changes
Nov 28, 2017
src/mon/PGMap.cc
Outdated
| @@ -845,8 +845,9 @@ void PGMapDigest::dump_object_stat_sum( | |||
| curr_object_copies_rate = (float)(sum.num_object_copies - sum.num_objects_degraded) / sum.num_object_copies; | |||
|
|
|||
| float used = 0.0; | |||
| //note avail passed in is raw_avail, calc raw_used here. | |||
There was a problem hiding this comment.
might want to add a space before "note"
Previous code forgot to multiple raw_used_ratio to calculate used byte. Fixes: http://tracker.ceph.com/issues/22247 Signed-off-by: Xiaoxi Chen <xiaoxchen@ebay.com>
xiaoxichen
force-pushed
the
fix_used_pct
branch
from
29fcfde
to
d10c6c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous code forgot to multiple raw_used_ratio to calculate
used byte.
Fixes: http://tracker.ceph.com/issues/22247
Signed-off-by: Xiaoxi Chen xiaoxchen@ebay.com