qa/ceph-disk: enlarge the simulated SCSI disk #19199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
normally, if we care about the output of ceph-disk, we expect a json string, and ceph-disk sends the output to stdout, and errors/warnings to stderr. so everything works as expected. and the test should also follow this tradition. for example, if deprecated warnings are printed, the warning message should not be collected along with the json string. see also: d44334f Signed-off-by: Kefu Chai <kchai@redhat.com>
it does not matter if we chown/restorecon before or after the rename,
but the logging message looks better this way: instead of fixing the
.tmp files, we are updating the attributes of the dest files w/o
.${pid}.tmp extension.
Signed-off-by: Kefu Chai <kchai@redhat.com>
logging.Logger.warn(format, *args). so no need to prepar a string for it. Signed-off-by: Kefu Chai <kchai@redhat.com>
Signed-off-by: Kefu Chai <kchai@redhat.com>
100MB will be allocated for journal, and the remaining 100MB is for data device. taking the inode into consideration, there will be approximately 87988 kB available for the activated OSD. and it will complain with a "nearfull" state. Fixes: http://tracker.ceph.com/issues/22136 Signed-off-by: Kefu Chai <kchai@redhat.com>
alfredodeza
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: http://tracker.ceph.com/issues/22136