cmake,common/RWLock: check for libpthread extensions #19202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LTGM, seems more reasonable |
cbodley
reviewed
Nov 28, 2017
| @@ -101,6 +101,7 @@ CHECK_FUNCTION_EXISTS(pthread_spin_init HAVE_PTHREAD_SPINLOCK) | |||
| CHECK_FUNCTION_EXISTS(pthread_set_name_np HAVE_PTHREAD_SET_NAME_NP) | |||
| CHECK_FUNCTION_EXISTS(pthread_setname_np HAVE_PTHREAD_SETNAME_NP) | |||
| CHECK_FUNCTION_EXISTS(pthread_getname_np HAVE_PTHREAD_GETNAME_NP) | |||
| CHECK_FUNCTION_EXISTS(pthread_rwlockattr_setkind_np HAVE_PTHREAD_RWLOCKATTR_SETKIND_NP) | |||
There was a problem hiding this comment.
this sets a cmake variable HAVE_PTHREAD_RWLOCKATTR_SETKIND_NP
to make that visible to the compiler, we also need to add a #cmakedefine for it in src/include/config-h.in.cmake
There was a problem hiding this comment.
@cbodley ahh, i forgot that! fixed and repushed.
pthread_rwlockattr_setkind_np() is a GNU extension of libpthread. and Tianshan Qu pointed out, we cannot use ifdef(PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP) to detect the availability of this function, because it's an enum not a macro. so, like other *_np() extensions, we check this one also using cmake at the configure phase. Reported-by: Tianshan Qu <tianshan@xsky.com> Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-check-pthread-ext
branch
from
cac1cab
to
cf50fb9
Compare
cbodley
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pthread_rwlockattr_setkind_np() is a GNU extension of libpthread. and
Tianshan Qu pointed out, we cannot use
ifdef(PTHREAD_RWLOCK_PREFER_WRITER_NONRECURSIVE_NP) to detect the
availability of this function, because it's an enum not a macro. so,
like other *_np() extensions, we check this one also using cmake at
the configure phase.
Reported-by: Tianshan Qu tianshan@xsky.com
Signed-off-by: Kefu Chai kchai@redhat.com