Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd: fix typos and some cleanups #19211

Merged
merged 3 commits into from Dec 15, 2017
Merged

osd: fix typos and some cleanups #19211

merged 3 commits into from Dec 15, 2017

Conversation

ZVampirEM77
Copy link
Contributor

  1. There are some unnecessary function called in PrimaryLogPG::find_object_context;

  2. Use __func__ for dout instead of an explicit function name;

  3. Update comment introduction for PrimaryLogPG::recover_missing return value;

@ZVampirEM77
osd: fix comment typos
ef12911 
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
@ZVampirEM77
osd: PrimaryLogPG cleanup unnecessary function called
1013988 
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
@ZVampirEM77
osd: PrimaryLogPG use __func__ instead of function name for dout
b103b49 
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
@ZVampirEM77
Copy link
Contributor Author

Jenkins, retest this please.

@ZVampirEM77
Copy link
Contributor Author

@tchaikov ping~

@ZVampirEM77
Copy link
Contributor Author

@liewegas @tchaikov ping~

@tchaikov
Copy link
Contributor

@tchaikov tchaikov merged commit 08f8826 into ceph:master Dec 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tchaikov tchaikov tchaikov approved these changes

@liewegas liewegas liewegas approved these changes

@amitkumar50 amitkumar50 amitkumar50 approved these changes

Assignees
No one assigned
Labels
cleanup core needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
5 participants
@ZVampirEM77 @tchaikov @liewegas @amitkumar50 @xiexingguo