Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/influx: PEP-8 and other fixes to Influx module #19229

Merged
merged 4 commits into from
Dec 13, 2017
Merged

mgr/influx: PEP-8 and other fixes to Influx module #19229

merged 4 commits into from
Dec 13, 2017

Commits on Dec 11, 2017

  1. mgr/influx: PEP-8 fixes to InfluxDB module 

    The code now scores:

  Your code has been rated at 8.94/10

Various indentation fixes, whitespaces and other PEP-8 related changes

Signed-off-by: Wido den Hollander <wido@42on.com>
    @wido
    wido committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    9440be3 View commit details
    Browse the repository at this point in the history

  2. mgr/influx: Send fsid as a tag to Influx to identify cluster 

    This allows for multiple Ceph clusters to send their data to the
same Influx database.

Using the fsid values for different clusters can be queried from
Influx

Signed-off-by: Wido den Hollander <wido@42on.com>
    @wido
    wido committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    2b71a89 View commit details
    Browse the repository at this point in the history

  3. mgr/influx: Revise configuration of module 

    It's a lot like the Zabbix module and allows for setting configuration
options on run-time and also fetch them from the module.

A few additional commands have been registered to make sure it is easy
to interact with the module.

Signed-off-by: Wido den Hollander <wido@42on.com>
    @wido
    wido committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    429718a View commit details
    Browse the repository at this point in the history

  4. mgr/influx: Print (in debug) time it takes to send data to Influx 

    On large clusters it might take a very long time to send data to Influx
due to the gathering and parsing of statistics.

By keeping a counter and printing it admins can adjust the interval if it
becomes to heavy for their cluster.

Signed-off-by: Wido den Hollander <wido@42on.com>
    @wido
    wido committed Dec 11, 2017
    Configuration menu
    Copy the full SHA
    3f07636 View commit details
    Browse the repository at this point in the history