Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: disable mon-health-to-clog in upgrade test #19233

Merged
merged 3 commits into from Dec 1, 2017
Merged

qa: disable mon-health-to-clog in upgrade test #19233

merged 3 commits into from Dec 1, 2017

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented Nov 29, 2017 •
edited

@tchaikov tchaikov added the tests label Nov 29, 2017
@tchaikov
qa/tasks/ceph_manager: add inject_args() method
a406553 
* move Thrasher._set_config() to CephManager, and make it a public
  method, and rename it to inject_args(),
* use this method instead of using 'tell ... injectargs ...' directly

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov force-pushed the wip-no-mon-health-to-clog-when-upgrading branch 2 times, most recently from c84aba7 to a1c069c Compare November 29, 2017 11:12
@tchaikov
qa/tasks/ceph: add mon-health-to-clog option to "restart"
185d2f5 
Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov force-pushed the wip-no-mon-health-to-clog-when-upgrading branch from a1c069c to 865304a Compare November 29, 2017 12:05
@tchaikov
Copy link
Contributor Author

http://pulpito.ceph.com/kchai-2017-11-29_12:05:32-rados-master-distro-basic-mira/

@tchaikov
qa: disable mon-health-to-clog in upgrade test
3aaf5d2 
otherwise the cluster will complain that the quorum size is smaller than
that of monmap.

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov force-pushed the wip-no-mon-health-to-clog-when-upgrading branch from 865304a to 3aaf5d2 Compare November 30, 2017 17:16
@tchaikov
Copy link
Contributor Author

tchaikov commented Dec 1, 2017 •
edited

@liewegas @jdurgin ping? i posted this fix twice[1]. and i found myself reimplemented it yesterday.

[1] #18931

liewegas
liewegas approved these changes Dec 1, 2017
View reviewed changes
Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! sorry for the delay

@tchaikov tchaikov merged commit 89c876d into ceph:master Dec 1, 2017
@tchaikov tchaikov deleted the wip-no-mon-health-to-clog-when-upgrading branch December 1, 2017 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

@jdurgin jdurgin Awaiting requested review from jdurgin

Assignees
No one assigned
Labels
needs-review tests
Projects
None yet
Milestone
No milestone
2 participants
@tchaikov @liewegas