New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rgw: fix GET website response error code #19236
Conversation
jenkins: retest this please |
thanks 👍 it looks like the s3tests in s3tests/functional/test_s3_website.py will accept either NoSuchKey or NoSuchWebsiteConfiguration, so i don't expect any test failures - but lets confirm with a teuthology run |
c1627a1
to
d5f2164
Compare
@yuriw done. Or should i rebase on master? |
@dplyakin I could not merge it on master will retry |
@dplyakin still no go :( --- pr 19236 --- pulling https://github.com/dplyakin/ceph.git branch get-website-error-code
|
Change NoSuchKey error code to NoSuchWebsiteConfiguration, when bucket doesn't have website configuration. Fixes: http://tracker.ceph.com/issues/22272 Signed-off-by: Dmitry Plyakin <dplyakin@gmail.com>
d5f2164
to
56344f0
Compare
@yuriw now it should be OK. |
@dplyakin 👍 yup, passed this one :) |
Change NoSuchKey error code to NoSuchWebsiteConfiguration, when bucket doesn't have website configuration.
Fixes: http://tracker.ceph.com/issues/22272
Signed-off-by: Dmitry Plyakin dplyakin@gmail.com
Backport PRs:
jewel: #19488
luminous: #19489