vstart.sh: drop .ceph_port and use randomly selected available port #19268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzafman
reviewed
Dec 1, 2017
| while [ true ] | ||
| do | ||
| CEPH_PORT="$(echo $(( RANDOM % 1000 + 40000 )))" | ||
| ss -a -n | egrep ":${CEPH_PORT} .+LISTEN" 1>/dev/null 2>&1 || break |
There was a problem hiding this comment.
This test is only partially useful since another process that happened to pick the same port could be racing to start daemons after doing this test.
|
could you prefix the title of your commit message with the subcomponent your are changing ? see https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst#3-describe-your-changes. we don't use "cleanup" as the prefix, in general. |
shinobu-x
force-pushed
the
vstart_picking_up_random_port
branch
from
09d6b6f
to
8de3dde
Compare
|
@tchaikov Like now? |
shinobu-x
changed the title
|
@shinobu-x i'd suggest |
shinobu-x
changed the title
vstart.sh becomes independent of do_cmake.sh Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
shinobu-x
force-pushed
the
vstart_picking_up_random_port
branch
from
8de3dde
to
5a3eed7
Compare
|
Are there any other users of that file? |
|
@gregsfortytwo What is |
batrick
approved these changes
Dec 1, 2017
liewegas
approved these changes
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vstart.sh becomes independent of do_cmake.sh
Signed-off-by: Shinobu Kinjo shinobu@redhat.com