cls_rgw: use more effective container operations in get_obj_vals #19272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks, looks good! we should probably add some extra test coverage to |
Signed-off-by: Xinying Song <songxinying@cloudin.cn>
cfanz
force-pushed
the
wip2-optimize-get_obj_vals
branch
from
e229a12
to
98c6eec
Compare
|
@cbodley I have added a test case. It writes 4 kinds utf8 object names: single byte, double byte, treble byte and quadruple byte, and one invalid object name belong to rgw's private namespace BI_PREFIX_CHAR. Except for BI_PREFIX_CHAR, other invalid utf8 characters will never occur in bucket index. So this test only examines whether BI_PREFIX_CHAR is filtered out. |
cbodley
approved these changes
Dec 11, 2017
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Xinying Song songxinying@cloudin.cn