journal: Trivial cleanup #19317
Merged
journal: Trivial cleanup #19317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dillaman
reviewed
Dec 4, 2017
src/journal/Journaler.cc
Outdated
| assert(m_trimmer == nullptr); | ||
| assert(m_player == nullptr); | ||
| assert(m_recorder == nullptr); | ||
| assert(!m_trimmer); |
There was a problem hiding this comment.
Nit: I prefer the original way (i.e. don't treat non-booleans as booleans).
dillaman
reviewed
Dec 4, 2017
src/journal/Journaler.cc
Outdated
| @@ -231,6 +237,7 @@ void Journaler::create(uint8_t order, uint8_t splay_width, | |||
| int r = m_header_ioctx.aio_operate(m_header_oid, comp, &op); | |||
| assert(r == 0); | |||
| comp->release(); | |||
| comp = nullptr; | |||
There was a problem hiding this comment.
Nit: it's a local variable going out-of-scope immediately
dillaman
reviewed
Dec 4, 2017
src/journal/Journaler.cc
Outdated
| os << *journaler.m_metadata; | ||
| } else { | ||
| os << "NULL"; | ||
| os << "nullptr"; |
shinobu-x
force-pushed
the
journaler_trivial_cleanup
branch
from
a721fbe
to
dbefacc
Compare
|
@dillaman Please check, when you get a chance. |
shinobu-x
force-pushed
the
journaler_trivial_cleanup
branch
3 times, most recently
from
4ac5c12
to
9c26f7e
Compare
dillaman
reviewed
Dec 5, 2017
src/journal/Journaler.cc
Outdated
| os << *journaler.m_metadata; | ||
| } else { | ||
| os << "NULL"; | ||
| os << "failed to find and replace"; |
There was a problem hiding this comment.
Nit: in my original comment, I was attempting to say no need to change this line
There was a problem hiding this comment.
@dillaman We should say something here which is more helpful for users, shouldn't we?
Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
shinobu-x
force-pushed
the
journaler_trivial_cleanup
branch
from
9c26f7e
to
fb50bde
Compare
|
@dillaman finally i noticed you're absolutely right. i deleted such a stupid change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shinobu Kinjo shinobu@redhat.com