rgw: add an option to clear all usage entries #19322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbodley
reviewed
Dec 20, 2017
src/cls/rgw/cls_rgw.cc
Outdated
| int rgw_usage_log_clear(cls_method_context_t hctx, bufferlist *in, bufferlist *out) | ||
| { | ||
| CLS_LOG(10,"%s", __func__); | ||
| /* only continue if object exists! */ |
There was a problem hiding this comment.
why is this stat needed? will map_clear not do the right thing if the object doesn't exist?
cbodley
reviewed
Dec 20, 2017
src/test/cls_rgw/test_cls_rgw.cc
Outdated
| ASSERT_EQ(0, ret); | ||
| ASSERT_EQ(0, usage2.size()); | ||
|
|
||
| } |
There was a problem hiding this comment.
could you please add some coverage for usage_log_clear() as well? it sounds like both the exist and noexist cases are interesting
This calls the omap clear api to clear all omap entries on an object which is useful if we ever want to fully reset the usage logs, also in case if the object doesn't exist we return immediately since in that case there are no omap entries on the object Added tests for cases when there is no object (which should return 0 as EINVAL is reraised) and when an object has over 2k entries Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Calling the cls_rgw_usage_log_clear() which in turn calls an omap clear to clear all the omap entries on an oid Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
Add an option that can clear all the usage stats recorded so far, this is more efficient than calling usage trim, since there we still have to loop against individual keys and check whether they match our stats. This is useful in use cases where usage data is already externally backed up in some sort of time series data base in which case Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com>
theanalyst
force-pushed
the
usage-trim-2
branch
from
1e95a17
to
d1a2235
Compare
|
@cbodley rebased and added new tests |
cbodley
approved these changes
Jan 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is built atop of #19131 (though
not dependant exactly, tests will be similar so will be rebased once
that is merged), adding an option to clear all the usage logs by using
the omap clear cls api, which would be faster for clearing usage log
entries of all users, we can't yet do this on a single user because
multiple users may map to a single oid. Adds a radosgw-admin cli command
called usage clear and implements these in the cls_rgw and rados layer