New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
debian/control: adjust ceph-{osdomap,kvstore,monstore}-tool feature move #19328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The backport didn't make 12.2.2, but it will be in 12.2.3. Fixes: http://tracker.ceph.com/issues/22319 Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-fix-tools-deb
branch
from
December 5, 2017 03:26
297654d
to
e0c8142
Compare
tchaikov
approved these changes
Dec 5, 2017
see also #18589 |
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Dec 6, 2017
this is a follow-up of ceph#19328. we need to get this change into 12.2.3. so better off do the switch somewhere after 12.2.2 which has been tagged, and before 12.2.3, which is not tagged yet. please note, this is not targetting master, because i want to make sure the change number (the <num> in << 12.2.2-<num>) is correct. it does not hurt if it's not, as long as it is ">> 12.2.2", so the replace machinery in 12.2.3 works, and it covers the releases where the ceph-{osdomap,kvstore,monstore}-tool are not move yet. but why don't make it more right? Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 57bb57f)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Dec 6, 2017
this is a follow-up of ceph#19328. we need to get this change into 12.2.3. so better off do the switch somewhere after 12.2.2 which has been tagged, and before 12.2.3, which is not tagged yet. please note, this is not targetting master, because i want to make sure the change number (the <num> in << 12.2.2-<num>) is correct. it does not hurt if it's not, as long as it is ">> 12.2.2", so the replace machinery in 12.2.3 works, and it covers the releases where the ceph-{osdomap,kvstore,monstore}-tool are not move yet. but why don't make it more right? Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Dec 6, 2017
this is a follow-up of ceph#19328. we need to get this change into 12.2.3. so better off do the switch somewhere after 12.2.2 which has been tagged, and before 12.2.3, which is not tagged yet. please note, this is not targetting master, because i want to make sure the change number (the <num> in << 12.2.2-<num>) is correct. it does not hurt if it's not, as long as it is ">> 12.2.2", so the replace machinery in 12.2.3 works, and it covers the releases where the ceph-{osdomap,kvstore,monstore}-tool are not move yet. but why don't make it more right? Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Dec 6, 2017
this is a follow-up of ceph#19328. we need to get this change into 12.2.3. so better off do the switch somewhere after 12.2.2 which has been tagged, and before 12.2.3, which is not tagged yet. please note, this is not targetting master, because i want to make sure the change number (the <num> in << 12.2.2-<num>) is correct. it does not hurt if it's not, as long as it is ">> 12.2.2", so the replace machinery in 12.2.3 works, and it covers the releases where the ceph-{osdomap,kvstore,monstore}-tool are not move yet. but why don't make it more right? Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit 57bb57f)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Dec 8, 2017
this is a follow-up of ceph#19328. we need to get this change into 12.2.3. so better off do the switch somewhere after 12.2.2 which has been tagged, and before 12.2.3, which is not tagged yet. please note, this is not targetting master, because i want to make sure the change number (the <num> in << 12.2.2-<num>) is correct. it does not hurt if it's not, as long as it is ">> 12.2.2", so the replace machinery in 12.2.3 works, and it covers the releases where the ceph-{osdomap,kvstore,monstore}-tool are not move yet. but why don't make it more right? Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit cdf49ba)
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jan 4, 2018
this is the rpm's counterpart of debian/control changes related to the ceph-{osdomap,kvstore,monstore}-tool feature move. see ceph#19328 and ceph#19356. the commit introducing this move is 6dba25e. and $ git describe 6dba25e v12.2.2-8-g6dba25e39d so the first release that have this change is 12.2.2-8. in other words, ceph-{base,osd,mon} >= 12.2.2.8 conflict with ceph-test < 12.2.2-8. Fixes: http://tracker.ceph.com/issues/22558 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jan 6, 2018
this is the rpm's counterpart of debian/control changes related to the ceph-{osdomap,kvstore,monstore}-tool feature move. see ceph#19328 and ceph#19356. the commit introducing this move is 6dba25e. and $ git describe 6dba25e v12.2.2-8-g6dba25e39d so the first release that have this change is 12.2.2-8. in other words, ceph-{base,osd,mon} >= 12.2.2.8 cannot co-exist with ceph-test < 12.2.2-8 in the same system. so we let ceph-test Requires ceph-common with the same version. and since ceph-{osd,mon} Requires ceph-base with the same version, and ceph-base Requires ceph-common with the same version, so by tiering ceph-test with ceph-common with the same version, we enforce this restriction. Fixes: http://tracker.ceph.com/issues/22558 Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jan 8, 2018
this is the rpm's counterpart of debian/control changes related to the ceph-{osdomap,kvstore,monstore}-tool feature move. see ceph#19328 and ceph#19356. the commit introducing this move is 6dba25e. and $ git describe 6dba25e v12.2.2-8-g6dba25e39d so the first release that have this change is 12.2.2-8. in other words, ceph-{base,osd,mon} >= 12.2.2.8 cannot co-exist with ceph-test < 12.2.2-8 in the same system. so we let ceph-test Requires ceph-common with the same version. and since ceph-{osd,mon} Requires ceph-base with the same version, and ceph-base Requires ceph-common with the same version, so by tiering ceph-test with ceph-common with the same version, we enforce this restriction. Fixes: http://tracker.ceph.com/issues/22558 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit b07aa21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The backport didn't make 12.2.2, but it will be in 12.2.3.
Signed-off-by: Sage Weil sage@redhat.com