osd: Use specializations, typedefs instead #19354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shinobu Kinjo <shinobu@redhat.com>
xiexingguo
approved these changes
Dec 6, 2017
tchaikov
reviewed
Dec 6, 2017
| @@ -774,7 +774,7 @@ class OSDService { | |||
|
|
|||
| private: | |||
| /// throttle promotion attempts | |||
| std::atomic_uint promote_probability_millis{1000}; ///< probability thousands. one word. | |||
| std::atomic<unsigned int> promote_probability_millis{1000}; ///< probability thousands. one word. | |||
There was a problem hiding this comment.
what's the rationale behind this change?
There was a problem hiding this comment.
adding @chardan
i don't feel strong either way. i just don't think we want to add code churn for no reason or just completely based on personal preference.
There was a problem hiding this comment.
@shinobu-x I have the same question as Kefu. The standard template specializations are well-defined, eg. std::atomic_uint is already exactly std::atomic.
There was a problem hiding this comment.
@shinobu-x Also, the title might need rewording, since this change /stops/ using typedef-ed specializations, the opposite of what it suggests.
|
@shinobu-x @tchaikov I'm still unclear on the purpose of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shinobu Kinjo shinobu@redhat.com