include: xlist: Fix Clang error for missing string #19367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
reviewed
Dec 7, 2017
src/include/xlist.h
Outdated
| @@ -207,7 +208,7 @@ class xlist { | |||
| bool first = true; | |||
| for (const auto &item : list) { | |||
| if (!first) { | |||
| oss << ", "; | |||
| oss << std::string(", "); | |||
There was a problem hiding this comment.
i think the right fix is to #include <ostream> in this header file.
There was a problem hiding this comment.
@tchaikov
Will try, thanx.
Clang complains:
home/jenkins/workspace/ceph-master/src/include/xlist.h:210:13: error: invalid operands to binary exp
ression ('std::ostream' (aka 'basic_ostream<char>') and 'const char *')
oss << ", ";
~~~ ^ ~~~~
1 error generated.
include ostream to fix Clang error
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wip-wjw-clang-xlist-string
branch
from
0bbd911
to
beca358
Compare
|
@tchaikov |
tchaikov
approved these changes
Dec 8, 2017
batrick
approved these changes
Dec 10, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clang complains:
So make sure that a string is a string.
Signed-off-by: Willem Jan Withagen wjw@digiware.nl