install-deps.sh: use DTS on centos if GCC is too old #19398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
2 times, most recently
from
062f266
to
3c84eea
Compare
|
@shinobu-x could you help test this? the goal here is to make sure that |
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
3 times, most recently
from
a89c585
to
987d06f
Compare
|
@tchaikov ack |
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
from
e5953c8
to
71873f7
Compare
|
|
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
2 times, most recently
from
c673062
to
decf048
Compare
please note, run-make-check.sh sources install-deps.sh here to import the $PATH and other environmental variables, which could be changed by the the DTS "enable" script. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
from
decf048
to
e68a3a2
Compare
|
@shinobu-x thanks for testing. fixed and repushed. |
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
3 times, most recently
from
835ede6
to
97dbcdb
Compare
the DTS-6 is only available in the testing repo Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
from
97dbcdb
to
1b24952
Compare
tchaikov
commented
Dec 8, 2017
| . /opt/rh/devtoolset-6/enable | ||
| %else | ||
| . /opt/rh/devtoolset-7/enable |
There was a problem hiding this comment.
@ktdreyer this reflects the different support of DTS from RHEL and CentOS.
|
lgtm! |
liewegas
approved these changes
Dec 8, 2017
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
from
1b24952
to
54030a3
Compare
devtoolset-7 is available for RHEL, but not for centos. only dts-6 is available for centos. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-install-deps-use-dts
branch
from
54030a3
to
b38621f
Compare
smithfarm
reviewed
Dec 15, 2017
| @@ -50,6 +50,38 @@ function ensure_decent_gcc { | |||
| $SUDO ln -nsf /usr/bin/g++ /usr/bin/x86_64-linux-gnu-g++ | |||
| } | |||
|
|
|||
| function version_lt { | |||
| test $1 != $(echo -e "$1\n$2" | sort -rV | head -n 1) | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kefu Chai kchai@redhat.com