Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install-deps.sh: install new gcc as the default the right way #19417

Merged
merged 1 commit into from Dec 9, 2017

Conversation

Projects
None yet
2 participants
@tchaikov
Copy link
Contributor

commented Dec 9, 2017

  • should install software-properties-common beforehand, otherwise
    the add-apt-repository command will not be available.
  • the update-alternative commandline were copied from ceph-build,
    should remove the escape characters.

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov tchaikov added the build/ops label Dec 9, 2017

@tchaikov tchaikov requested a review from liewegas Dec 9, 2017

install-deps.sh: install new gcc as the default the right way
* should install software-properties-common beforehand, otherwise
  the `add-apt-repository` command will not be available.
* the update-alternative commandline were copied from ceph-build,
  should remove the escape characters.

Signed-off-by: Kefu Chai <kchai@redhat.com>

@tchaikov tchaikov force-pushed the tchaikov:wip-install-deps-gcc branch from c3e8ee4 to 3882dea Dec 9, 2017

@tchaikov tchaikov merged commit 7175910 into ceph:master Dec 9, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@tchaikov tchaikov deleted the tchaikov:wip-install-deps-gcc branch Dec 9, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.