Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: assertion with --bind and invalid ip address #19419

Closed
wants to merge 1 commit into from
Closed

common: assertion with --bind and invalid ip address #19419

wants to merge 1 commit into from

Conversation

shinobu-x
Copy link
Contributor

fix: http://tracker.ceph.com/issues/22358

Signed-off-by: Shinobu Kinjo shinobu@redhat.com

@shinobu-x shinobu-x force-pushed the config_bind_check branch 2 times, most recently from 1ee56d3 to 1d53a5c Compare December 10, 2017 05:00
@wjwithagen
Copy link
Contributor

So how about IPv6??

And why do all this work, when the socket routines will tell you that it is an invalid address??

shinobu-x
shinobu-x commented Dec 10, 2017
View reviewed changes
src/common/config.cc Outdated
if (!boost::regex_match(val.c_str(), e)) {
std::cerr << "error: invalid ip address " << val.c_str() << std::endl;
_exit(1);
}
set_val_or_die("public_addr", val.c_str());
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wjwithagen it's up to what's expected value for public_addr.

@tchaikov
Copy link
Contributor

retest this please

@tchaikov
Copy link
Contributor

retest this please.

@stale
Copy link

stale bot commented Oct 18, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 18, 2018
@liewegas
Copy link
Member

I think this belongs in teh config value checker for the address type (for the bind config option), and then switch to something other than set_val_or_die so we can return a friendly error

@liewegas liewegas closed this Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cleanup stale
Projects
None yet
Milestone
No milestone
4 participants
@shinobu-x @wjwithagen @tchaikov @liewegas