Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

osd/PG: handle flushed event directly #19441

Merged
merged 1 commit into from Jan 10, 2018
Merged

osd/PG: handle flushed event directly #19441

merged 1 commit into from Jan 10, 2018

Conversation

wumingqiao
Copy link
Contributor

same logic as before, but avoid queueing and thread switching

Signed-off-by: wumingqiao wumingqiao@inspur.com

@wumingqiao
PG: handle flushed event directly
9dfd251 
Signed-off-by: wumingqiao <wumingqiao@inspur.com>
@wumingqiao wumingqiao mentioned this pull request Dec 12, 2017
Closed
@tchaikov
Copy link
Contributor

tchaikov commented Dec 12, 2017 •
edited

per sage's comment,

Ok, I'd like to keep this in testing limbo for several runs. In particular, I'd like to combine it with #18752 . The flush evt behavior dates back to 2012 so I'm a bit paranoid :)

that's why this PR is labeled with DNM and needs-qa.

@wumingqiao
Copy link
Contributor Author

I understand, and this pr is more or less insignificant

@tchaikov
Copy link
Contributor

@wumingqiao i was simply copying the message to help other reviewers. i think the reason Sage holds your PR is not that it's insignificant, but just "Better To Be Sure Than Sorry".

@liewegas liewegas changed the title PG: handle flushed event directly osd/PG: handle flushed event directly Dec 12, 2017
@tchaikov
Copy link
Contributor

@tchaikov
Copy link
Contributor

@tchaikov
Copy link
Contributor

@tchaikov
Copy link
Contributor

@liewegas is this change good to merge?

@liewegas liewegas merged commit 206a53e into ceph:master Jan 10, 2018
@liewegas
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

Assignees
No one assigned
Labels
DNM needs-qa
Projects
None yet
Milestone
No milestone
3 participants
@wumingqiao @tchaikov @liewegas