Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qa/standalone/ceph-helpers: pass --verbose to ceph-disk #19456

Merged
merged 1 commit into from Dec 19, 2017

Conversation

Projects
None yet
2 participants
@liewegas
Copy link
Member

commented Dec 12, 2017

Signed-off-by: Sage Weil sage@redhat.com

@@ -582,7 +582,7 @@ function run_osd() {

mkdir -p $osd_data
ceph-disk $ceph_disk_args \
prepare --filestore $osd_data || return 1
prepare --filestore $osd_data --verbose || return 1

This comment has been minimized.

Copy link
@alfredodeza

alfredodeza Dec 12, 2017

Contributor

this will not work for prepare because --verbose is a global (top level) argument. So what you need here is:

ceph-disk --verbose $ceph_disk_args \
    prepare --filestore $osd_data || return 1
qa/standalone/ceph-helpers: pass --verbose to ceph-disk
Signed-off-by: Sage Weil <sage@redhat.com>

@liewegas liewegas force-pushed the liewegas:wip-22373 branch from bb6e890 to 86dc162 Dec 12, 2017

@liewegas liewegas merged commit 06b7707 into ceph:master Dec 19, 2017

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@liewegas liewegas deleted the liewegas:wip-22373 branch Dec 19, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.