Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceph-volume: Add linesep/newline at end of JSON file when writing #19458

Merged
merged 1 commit into from Dec 16, 2017

Conversation

Projects
None yet
2 participants
@wido
Copy link
Member

commented Dec 12, 2017

Instead of:

    "systemd": "",
    "type": "bluestore",
    "whoami": "0"
  }root@alpha:~#

A newline is added to the JSON file when writing:

    "type": "bluestore",
    "whoami": "0"
  }
  root@alpha:~#

Makes it a bit easier to read the JSON files on a terminal

Signed-off-by: Wido den Hollander wido@42on.com

ceph-volume: Add linesep/newline at end of JSON file when writing
Instead of:

    "systemd": "",
    "type": "bluestore",
    "whoami": "0"
  }root@alpha:~#

A newline is added to the JSON file when writing:

    "type": "bluestore",
    "whoami": "0"
  }
  root@alpha:~#

Makes it a bit easier to read the JSON files on a terminal

Signed-off-by: Wido den Hollander <wido@42on.com>

@wido wido added the ceph-volume label Dec 12, 2017

@wido wido requested a review from alfredodeza Dec 12, 2017

@alfredodeza
Copy link
Contributor

left a comment

@andrewschoen want to take a look? I guess this would still load fine

@alfredodeza

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2017

jenkins test ceph-volume tox

@alfredodeza

This comment has been minimized.

Copy link
Contributor

commented Dec 14, 2017

@wido to test this we will need this branch on ceph-ci.git

Mind pushing there?

@wido

This comment has been minimized.

Copy link
Member Author

commented Dec 16, 2017

Done! It's in the CI repo as well

@alfredodeza

This comment has been minimized.

Copy link
Contributor

commented Dec 16, 2017

The only failure here was ceph-disk not being able to activate:

mount_activate: Failed to activate

Everything on ceph-volume's side for the simple sub-command worked. This looks good to go. Thank you @wido for the PR

@alfredodeza alfredodeza merged commit 4ee0e9e into ceph:master Dec 16, 2017

9 of 10 checks passed

"ceph-volume simple testing xenial-bluestore-activate" "failed"
Details
"ceph-volume simple testing centos7-bluestore-activate" "OK"
Details
"ceph-volume simple testing centos7-filestore-activate" "OK"
Details
"ceph-volume simple testing xenial-filestore-activate" "OK"
Details
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
ceph-volume tox testing ceph-volume tox OK
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.