ceph-volume: Add linesep/newline at end of JSON file when writing #19458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of:
"systemd": "",
"type": "bluestore",
"whoami": "0"
}root@alpha:~#
A newline is added to the JSON file when writing:
"type": "bluestore",
"whoami": "0"
}
root@alpha:~#
Makes it a bit easier to read the JSON files on a terminal
Signed-off-by: Wido den Hollander <wido@42on.com>
alfredodeza
approved these changes
Dec 13, 2017
There was a problem hiding this comment.
@andrewschoen want to take a look? I guess this would still load fine
|
jenkins test ceph-volume tox |
|
@wido to test this we will need this branch on ceph-ci.git Mind pushing there? |
|
Done! It's in the CI repo as well |
|
The only failure here was ceph-disk not being able to activate: Everything on ceph-volume's side for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of:
"systemd": "", "type": "bluestore", "whoami": "0" }root@alpha:~#A newline is added to the JSON file when writing:
"type": "bluestore", "whoami": "0" } root@alpha:~#Makes it a bit easier to read the JSON files on a terminal
Signed-off-by: Wido den Hollander wido@42on.com