osd: fix unordered read bug (for chunked object) #19464
Conversation
myoungwon
force-pushed
the
wip-bug-fix-22369
branch
from
f91e43d
to
d70b71a
Compare
The current implementation for chunked object only supports proxy_read(if offset is within range) and write(local write) In this case, a read request can be handled before a write request. This commit prevents unordered read processing because proxy_read() will be executed if the chunk is missing state. If chunked object has been overwritten, its state will not be missing. Fixes: http://tracker.ceph.com/issues/22369 Signed-off-by: Myoungwon Oh <omwmw@sk.com>
|
retest this please |
myoungwon
force-pushed
the
wip-bug-fix-22369
branch
from
9a4845d
to
a250483
Compare
current chunked object and ChunkReadOp are only for the read case. write op and promote_object() still be tested without ChunkReadOp by another ceph_test_rados in the same test suite (with --set_chunk) Signed-off-by: Myoungwon Oh <omwmw@sk.com>
This commit prevents unnecessary stat that invokes promote_object() promote_object() makes object clean state Signed-off-by: Myoungwon Oh <omwmw@sk.com>
|
@myoungwon i'd suggest contributor comment on the PR to explain what change he/she made if the PR is updated after it's reviewed/approved. otherwise we can hardly tell if the test is valid or not. |
|
@tchaikov Sorry, The main purpose of updated commit is to make a chunk MISSING state when ChunkReadOp test is executed. Since stat and write op make a chunk CLEAN state (through promote_object), this causes local read (not chunk_proxy_read). If flush() is implemented (#19294), combination test (promote , flush, write and read ...) will be added. Do you need more explanation? |
|
@myoungwon i have not reviewed this change, so it's up to the reviewer. i just wanted to understand if it's safe to merge. because @liewegas has approved your PR. but it's risky to merge as it is without confirming with you. |
The current implementation for chunked object only supports
proxy_read(if offset is within range) and write(local write)
In this case, a read request can be handled before a write request.
This commit prevents unordered read processing because
proxy_read() will be executed if the chunk is missing state.
If chunked object has been overwritten, its state will not be missing.
Fixes: http://tracker.ceph.com/issues/22369
Signed-off-by: Myoungwon Oh omwmw@sk.com