rgw: remove redundant S3AnonymousEngine #19474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* When receives unauthorized requests, RGW(rados auth only) runs four * engines as follows: * 1. anonymous engine in s3_main_strategy_plain * 2. local engine in s3_main_strategy_plain * 3. anonymous engine in s3_main_strategy_boto2 * 4. local engine in s3_main_strategy_boto2 * The third engine which is exactly the same with the first one is * redundant. Signed-off-by: Bingyin Zhang <zhangbingyin@cloudin.cn>
|
hi, @cbodley, @rzarzynski, would you help to review this? thanks! |
rzarzynski
approved these changes
Dec 13, 2017
rzarzynski
reviewed
Dec 13, 2017
| @@ -30,7 +30,7 @@ class StrategyRegistry { | |||
| using s3_main_strategy_plain_t = \ | |||
| s3_strategy_t<rgw::auth::s3::AWSGeneralAbstractor, true>; | |||
| using s3_main_strategy_boto2_t = \ | |||
| s3_strategy_t<rgw::auth::s3::AWSGeneralBoto2Abstractor, true>; | |||
| s3_strategy_t<rgw::auth::s3::AWSGeneralBoto2Abstractor>; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receives unauthorized requests, RGW(rados auth only) runs four engines as follows:
The third engine which is exactly the same with the first one is redundant.