rbd: 'trash list --long' will return a failure on non-cloned images #19540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trociny
reviewed
Dec 15, 2017
| @@ -236,8 +236,12 @@ int do_list(librbd::RBD &rbd, librados::IoCtx& io_ctx, bool long_flag, | |||
|
|
|||
| std::string pool, image, snap, parent; | |||
| r = im.parent_info(&pool, &image, &snap); | |||
| if (r < 0 && r != -ENOENT) | |||
| if (r == -ENOENT) { | |||
| r = 0; | |||
There was a problem hiding this comment.
@dillaman we have if (r != -ENOENT) block below.
There was a problem hiding this comment.
Yeah -- but since it doesn't exit and doesn't clear the error code, that -ENOENT error code will be returned when the function exits here: https://github.com/ceph/ceph/pull/19540/files#diff-8a78f96557c8ae5b23b41bc6330c430bR286
dillaman
force-pushed
the
wip-rbd-trash-list-enoent
branch
from
efcf429
to
1cf16c2
Compare
dillaman
changed the title
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
dillaman
force-pushed
the
wip-rbd-trash-list-enoent
branch
from
1cf16c2
to
bed3356
Compare
runsisi
pushed a commit
to runsisi/ceph
that referenced
this pull request
Mar 20, 2018
rbd: 'trash list --long' will return a failure on non-cloned images Reviewed-by: Mykola Golub <to.my.trociny@gmail.com> (cherry picked from commit 18b9219)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jason Dillaman dillaman@redhat.com