osd/PG: some cleanups && add should_gather filter for loop logging #19546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
Signed-off-by: Enming Zhang <enming.zhang@umcloud.com>
shinobu-x
suggested changes
Dec 15, 2017
| @@ -1237,10 +1237,11 @@ void PG::calc_replicated_acting( | |||
| set<pg_shard_t> *acting_backfill, | |||
| ostream &ss) | |||
| { | |||
| ss << "calc_acting newest update on osd." << auth_log_shard->first | |||
| pg_shard_t auth_log_shard_id = auth_log_shard->first; | |||
There was a problem hiding this comment.
what could be improved whit this local variable?
There was a problem hiding this comment.
Actually, the local variable pg_shard_t auth_log_shard_id is already existent before, I just change the location of its definition to reduce calling times of auth_log_shard->first. I think there will be a little bit improvement (although it can be ignored) to execution efficiency, or at least it makes the code looks more clean.
liewegas
approved these changes
Dec 20, 2017
liewegas
changed the title
tchaikov
approved these changes
Jan 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three things:
add should_gather filter before for loop logging in choose_acting
use func instead of an explicit function name for
doutin choose_actingclean up repeated calling and use func instead of an explicit function name for
doutin calc_replicated_acting