Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qa: check pool full flags #19588

Merged
merged 1 commit into from Dec 21, 2017
Merged

qa: check pool full flags #19588

merged 1 commit into from Dec 21, 2017

Conversation

batrick
Copy link
Member

@batrick batrick commented Dec 19, 2017

Cluster-wide flag removed in b4ca5ae.

Signed-off-by: Patrick Donnelly pdonnell@redhat.com

@batrick batrick added bug-fix cephfs Ceph File System labels Dec 19, 2017
@batrick
qa: check pool full flags
6e046df 
Cluster-wide flag removed in b4ca5ae.

Fixes: http://tracker.ceph.com/issues/22475

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
@yuriw
Copy link
Contributor

yuriw commented Dec 19, 2017

wip-yuri4-testing-2017-12-19-1722

@batrick
Copy link
Member Author

batrick commented Dec 19, 2017

@yuriw still working on this so it's not ready yet for testing.

@batrick batrick changed the title qa: check pool full flags [DNM] qa: check pool full flags Dec 19, 2017
@batrick batrick added the DNM label Dec 19, 2017
@yuriw
Copy link
Contributor

yuriw commented Dec 19, 2017 •
edited

@batrick this is part of mimic-dev1 branch we are testing now
And will run tests as soon as this https://shaman.ceph.com/builds/ceph/wip-yuri4-testing-2017-12-19-1722/ is built

@batrick
Copy link
Member Author

batrick commented Dec 19, 2017

It hasn't been merged into mimic-dev1 yet?

Anyway, it's fine if you're testing this but it doesn't fix the problem yet.

@batrick batrick removed the DNM label Dec 19, 2017
@batrick batrick changed the title [DNM] qa: check pool full flags qa: check pool full flags Dec 19, 2017
@batrick
Copy link
Member Author

batrick commented Dec 19, 2017

Nevermind, this patch fixes the issue as advertised but there are other issues.

http://tracker.ceph.com/issues/22482

liewegas
liewegas approved these changes Dec 19, 2017
View reviewed changes
Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for the test. Did another patch fix the mds/Server.cc check?

@batrick
Copy link
Member Author

batrick commented Dec 19, 2017

@liewegas #19602

batrick added a commit to batrick/ceph that referenced this pull request Dec 21, 2017
@batrick
Merge PR ceph#19588 into wip-pdonnell-testing-20171219.201209
71d89fd 
* refs/pull/19588/head:
	qa: check pool full flags
@liewegas liewegas merged commit 1a549a0 into ceph:mimic-dev1 Dec 21, 2017
@batrick batrick deleted the i22475 branch December 21, 2017 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liewegas liewegas liewegas approved these changes

@ukernel ukernel Awaiting requested review from ukernel

Assignees
No one assigned
Labels
bug-fix cephfs Ceph File System wip-yuri4-testing
Projects
None yet
Milestone
No milestone
3 participants
@batrick @yuriw @liewegas