Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: expand developer documentation of unit tests #19594

Merged
merged 2 commits into from Apr 6, 2018

Conversation

smithfarm
Copy link
Contributor

Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm
Copy link
Contributor Author

@mogeb @chardan @tchaikov

@smithfarm smithfarm force-pushed the wip-doc-make-check branch 2 times, most recently from 1272a4e to f1d5f6e Compare December 19, 2017 10:32
@smithfarm
Copy link
Contributor Author

jenkins build docs

@smithfarm
Copy link
Contributor Author

jenkins test docs

@smithfarm
Copy link
Contributor Author

Warning, treated as error:
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/dev/index.rst:725:Unknown target name: "ctest".

Signed-off-by: Nathan Cutler <ncutler@suse.com>
@smithfarm
Copy link
Contributor Author

jenkins test docs

2 similar comments
@smithfarm
Copy link
Contributor Author

jenkins test docs

@smithfarm
Copy link
Contributor Author

jenkins test docs

@smithfarm
Copy link
Contributor Author

Fishing for a review so this could be merged.

@@ -708,19 +708,24 @@ chapters examine the `make check`_ and integration tests in detail.
Testing - make check
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to replace the heading with "Unit Tests - make check"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LenzGr Yes, it would. Added a commit to address this.

Signed-off-by: Nathan Cutler <ncutler@suse.com>
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@smithfarm
Copy link
Contributor Author

jenkins build docs

@smithfarm
Copy link
Contributor Author

jenkins render docs

@ceph-jenkins
Copy link
Collaborator

Doc render available at http://docs.ceph.com/ceph-prs/19594/

@smithfarm smithfarm merged commit bdb6746 into ceph:master Apr 6, 2018
@smithfarm smithfarm deleted the wip-doc-make-check branch April 6, 2018 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants