Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: expand developer documentation of unit tests #19594

Merged
merged 2 commits into from Apr 6, 2018

Conversation

Projects
None yet
3 participants
@smithfarm
Copy link
Contributor

commented Dec 19, 2017

Signed-off-by: Nathan Cutler ncutler@suse.com

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

@smithfarm smithfarm force-pushed the smithfarm:wip-doc-make-check branch 2 times, most recently from 1272a4e to f1d5f6e Dec 19, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

jenkins build docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

jenkins test docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 19, 2017

Warning, treated as error:
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/dev/index.rst:725:Unknown target name: "ctest".
doc: expand developer documentation of unit tests
Signed-off-by: Nathan Cutler <ncutler@suse.com>

@smithfarm smithfarm force-pushed the smithfarm:wip-doc-make-check branch from f1d5f6e to fd8461b Dec 19, 2017

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2017

jenkins test docs

2 similar comments
@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 20, 2017

jenkins test docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2017

jenkins test docs

@smithfarm smithfarm requested review from tchaikov, mogeb, badone and gregsfortytwo Apr 6, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

Fishing for a review so this could be merged.

@@ -708,19 +708,24 @@ chapters examine the `make check`_ and integration tests in detail.
Testing - make check

This comment has been minimized.

Copy link
@LenzGr

LenzGr Apr 6, 2018

Contributor

Would it make sense to replace the heading with "Unit Tests - make check"?

This comment has been minimized.

Copy link
@smithfarm

smithfarm Apr 6, 2018

Author Contributor

@LenzGr Yes, it would. Added a commit to address this.

doc: dev: improve headings within Testing chapter
Signed-off-by: Nathan Cutler <ncutler@suse.com>
@LenzGr

LenzGr approved these changes Apr 6, 2018

Copy link
Contributor

left a comment

LGTM!

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

jenkins build docs

@smithfarm

This comment has been minimized.

Copy link
Contributor Author

commented Apr 6, 2018

jenkins render docs

@ceph-jenkins

This comment has been minimized.

Copy link
Collaborator

commented Apr 6, 2018

Doc render available at http://docs.ceph.com/ceph-prs/19594/

@smithfarm smithfarm merged commit bdb6746 into ceph:master Apr 6, 2018

5 of 6 checks passed

make check (arm64) make check failed
Details
Docs: build check OK - docs built
Details
Docs: render build OK - docs rendered
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details

@smithfarm smithfarm deleted the smithfarm:wip-doc-make-check branch Apr 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.