Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

packaging: explicit jinja2 dependency for dashboard #19598

Merged
merged 1 commit into from Jan 5, 2018

Conversation

Projects
None yet
4 participants
@jcsp
Copy link
Contributor

commented Dec 19, 2017

We were getting this via python-flask when mgr nodes were also mon nodes, but the mgr should depend on it explicitly to work in all cases.

Fixes: http://tracker.ceph.com/issues/22457
Signed-off-by: John Spray john.spray@redhat.com

@jcsp jcsp added bug fix mgr labels Dec 19, 2017

John Spray
packaging: explicit jinja2 dependency for dashboard
We were getting this via python-flask, when mgr was
installed on nodes with ceph-mon, but for correctness
in general we should depend on it from ceph-mgr (it
is imported by the dashboard module).

Fixes: http://tracker.ceph.com/issues/22457
Signed-off-by: John Spray <john.spray@redhat.com>

@jcsp jcsp force-pushed the jcsp:wip-22457 branch from 97a68c4 to 87399be Dec 19, 2017

@wido

wido approved these changes Dec 19, 2017

Copy link
Member

left a comment

Looks good to me!

@jcsp jcsp added the needs-qa label Jan 2, 2018

@tchaikov tchaikov merged commit 4fda7cc into ceph:master Jan 5, 2018

5 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
make check (arm64) make check succeeded
Details

@smithfarm smithfarm added the build/ops label Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.