[DNM] jewel: rgw: dont log EBUSY errors in 'sync error list' #19638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
these temporary errors get retried automatically, so no admin intervention is required. logging them only serves to waste space in omap and obscure the more serious sync errors Fixes: http://tracker.ceph.com/issues/22473 Signed-off-by: Casey Bodley <cbodley@redhat.com> (cherry picked from commit ca4510b) Signed-off-by: Matt Benjamin <mbenjamin@redhat.com>
mattbenjamin
changed the title
cbodley
reviewed
Jan 2, 2018
| yield call(sync_env->error_logger->log_error_cr(sync_env->conn->get_remote_id(), "data", raw_key, | ||
| -sync_status, string("failed to sync bucket instance: ") + cpp_strerror(-sync_status))); | ||
| if (retcode < 0) { | ||
| tn->log(0, SSTR("ERROR: failed to log sync failure: retcode=" << retcode)); |
There was a problem hiding this comment.
tn here is part of the sync tracing which wasn't backported to jewel. i think this line needs to remain as ldout()
smithfarm
changed the title
|
Duplicate backport PR is open at #19908 |
|
closing in favor of #19908 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport tracker: http://tracker.ceph.com/issues/22582
these temporary errors get retried automatically, so no admin
intervention is required. logging them only serves to waste space in
omap and obscure the more serious sync errors
Fixes: http://tracker.ceph.com/issues/22473
Signed-off-by: Casey Bodley cbodley@redhat.com
(cherry picked from commit ca4510b)
Signed-off-by: Matt Benjamin mbenjamin@redhat.com