Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rbd-ggate: small fixes and improvements #19679

Merged
merged 4 commits into from Dec 29, 2017
Merged

rbd-ggate: small fixes and improvements #19679

merged 4 commits into from Dec 29, 2017

Conversation

trociny
Copy link
Contributor

@trociny trociny commented Dec 25, 2017

No description provided.

@trociny
rbd-ggate: honor rbd_default_pool config setting
412a3c4 
Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
@trociny
rbd-ggate: output error on map failure
3905b6e 
Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
@wjwithagen
Copy link
Contributor

Running it thru FreeBSD-jenkins

@trociny trociny changed the title rbd- ggate: small fixes and improvements rbd-ggate: small fixes and improvements Dec 25, 2017
@wjwithagen wjwithagen self-requested a review December 26, 2017 13:12
wjwithagen
wjwithagen approved these changes Dec 26, 2017
View reviewed changes
Copy link
Contributor

@wjwithagen wjwithagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FreeBSD-jenkins exectues oke.
http://cephdev.digiware.nl:8180/jenkins/job/ceph-master/1598/console

@trociny
rbd-ggate: extended info when listing devices
8e0f40a 
This matches nbd and krbd drivers output.

Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
@trociny
rbd-ggate: allow to unmap by image or snap spec
be87e8b 
(to match the behaviour of krbd unmap)

Signed-off-by: Mykola Golub <to.my.trociny@gmail.com>
@trociny
Copy link
Contributor Author

trociny commented Dec 27, 2017

Updated: support is added for different output formats for list command. Though it might require additional tweaking after discussing the format for rbd-nbd list-mapped command in #19704.

@wjwithagen
Copy link
Contributor

@trociny
Let me know if you want another FreeBSD-jenkins run.

@wjwithagen
Copy link
Contributor

wjwithagen commented Dec 28, 2017 •
edited

@trociny
It looks like this patch is cont compatible with #19711?
But could be cause I did not include the last 2 commits.

@trociny
Copy link
Contributor Author

trociny commented Dec 29, 2017

@wjwithagen It will probably require resolving some conflicts if you want to test this together with #19711. I will resolve this after one of this is merged to the master.

Right now I don't think there is a need for FreeBSD-jenkins run. I would like to discuss with @dillaman the formatted output structure first, so it will probably be updated. I guess this will happen the next year though )

@liewegas liewegas merged commit 1a9a442 into ceph:master Dec 29, 2017
@trociny trociny mentioned this pull request Dec 29, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjwithagen wjwithagen wjwithagen approved these changes

Assignees
No one assigned
Labels
feature rbd
Projects
None yet
Milestone
No milestone
3 participants
@trociny @wjwithagen @liewegas