rgw: the metavariables in frontends-related config won't be expanded #19689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using metavariables in frontends-related config, I found that metavariables won't be expanded. Such as: the `name` variable won't be expanded. ``` [client.rgw] rgw frontends = civetweb port=8000 access_log_file=/path/$name.access.log ``` The reason is as follows: In `rgw_main.cc/main()` function, program uses frontends-related config before the `expand_all_meta` function call that is called in the `global_init` function. Signed-off-by: chnmagnus chnmagnus@qq.com
liewegas
approved these changes
Dec 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using metavariables in frontends-related config, I found that metavariables won't be expanded. Such as:
The
namevariable won't be expanded.The reason is as follows:
In
rgw_main.cc/mainfunction, program uses frontends-related config before theexpand_all_metafunction call that is called in theglobal_initfunction.Signed-off-by: chnmagnus chnmagnus@qq.com