rgw: optimize function abort_bucket_multiparts #19710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qrGitHub
commented
Dec 28, 2017
•
qrGitHub
commented
- common_prefixes is useless, so drop it;
- RGWMPObj object is enough, so change RGWMultipartUploadEntry to RGWMPObj;
amitkumar50
reviewed
Dec 31, 2017
src/rgw/rgw_multi.cc
Outdated
| bool is_truncated; | ||
| string marker; |
There was a problem hiding this comment.
whystring marker place is changed?
src/rgw/rgw_multi.cc
Outdated
| if (ret < 0) { | ||
| return ret; | ||
| } | ||
| num_deleted++; | ||
| } | ||
| if (num_deleted) { | ||
| ldout(store->ctx(),0) << "WARNING : aborted " << num_deleted << " incomplete multipart uploads" << dendl; | ||
| ldout(store->ctx(), 0) << "WARNING: aborted " << num_deleted << |
qrGitHub
force-pushed
the
wip-rgw-optimize-function2
branch
from
295e5b3
to
25c7718
Compare
|
@amitkumar50 withdraw unnecessary changes |
yehudasa
reviewed
Jan 2, 2018
src/rgw/rgw_multi.cc
Outdated
| bool is_truncated; | ||
|
|
||
| do { | ||
| ret = list_bucket_multiparts(store, bucket_info, prefix, marker, delim, | ||
| max, &objs, &common_prefixes, &is_truncated); | ||
| max, &objs, NULL, &is_truncated); |
There was a problem hiding this comment.
@qrGitHub use nullptr instead of NULL
* 1. common_prefixes is useless, so drop it; * 2. RGWMPObj object is enough, so change RGWMultipartUploadEntry to RGWMPObj; Signed-off-by: Bingyin Zhang <zhangbingyin@cloudin.cn>
qrGitHub
force-pushed
the
wip-rgw-optimize-function2
branch
from
25c7718
to
fe7d415
Compare
|
change NULL to nullptr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.