os/bluestore: refactor FreeListManager to get clearer view on the number #19718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
reviewed
Dec 29, 2017
src/os/bluestore/StupidAllocator.cc
Outdated
| @@ -8,7 +8,8 @@ | |||
| #define dout_context cct | |||
| #define dout_subsys ceph_subsys_bluestore | |||
| #undef dout_prefix | |||
| #define dout_prefix *_dout << "stupidalloc " | |||
| #define dout_prefix *_dout << "stupidalloc 0x" << std::hex\ | |||
| << this << " " << std::dec | |||
There was a problem hiding this comment.
fwiw pointers format in hex automatically
liewegas
approved these changes
Dec 29, 2017
ifed01
force-pushed
the
wip-ifed-freelist-cleanup
branch
from
cc1907b
to
c47dd63
Compare
of alloc units it tracks. This also fixes out-of-range access for fsck's used_blocks bitmap that might happen when checking stores created prior to v12.2.2 Fixes http://tracker.ceph.com/issues/22535 Signed-off-by: Igor Fedotov <ifedotov@suse.com>
boost doesn't always handle out-of-range access properly. Signed-off-by: Igor Fedotov <ifedotov@suse.com>
ifed01
force-pushed
the
wip-ifed-freelist-cleanup
branch
from
c47dd63
to
121c402
Compare
|
@liewegas - please review once again, I extended the PR to catch and fix http://tracker.ceph.com/issues/22535 |
liewegas
approved these changes
Dec 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
of alloc units it tracks
This should make relations between FreeListManager and BlueStore::_fsck a bit less error-prone as the former will encapsulate more internal details: number of allocation units it tracks, aligned block boundaries during enumeration, etc.
Signed-off-by: Igor Fedotov ifedotov@suse.com