Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd: support class method whitelisting within caps #19786

Merged
merged 4 commits into from Jan 8, 2018

Conversation

dillaman
Copy link

@dillaman dillaman commented Jan 4, 2018

RBD is planning to utilize this to support simplified cloning by allowing users with read-only access to a pool to be able to execute a read/write class method to manage the child clone references.

Jason Dillaman added 4 commits January 4, 2018 09:55
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
Copy link
Member

@gregsfortytwo gregsfortytwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One thing to call out: this syntax requires a separate clause for each class method the client is allowed to invoke. That's maybe a little bit awkward, but is also consistent with our existing grants and easy to understand.

@yuriw
Copy link
Contributor

yuriw commented Jan 5, 2018

@yuriw yuriw merged commit 5784779 into ceph:master Jan 8, 2018
@dillaman dillaman deleted the wip-osd-class-cap branch January 8, 2018 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants