cmake: update minimum boost version to 1.66 #19808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Casey Bodley <cbodley@redhat.com>
Fixes: http://tracker.ceph.com/issues/22600 Signed-off-by: Casey Bodley <cbodley@redhat.com>
the beast library is included in boost 1.66 Signed-off-by: Casey Bodley <cbodley@redhat.com>
adds a more specific option for this boost::context dependency, which was previously only used by the radosgw beast frontend. see http://tracker.ceph.com/issues/20048 for more background Signed-off-by: Casey Bodley <cbodley@redhat.com>
|
this contains the cmake changes for boost 1.66 from #19054, which were reviewed and tested there |
tchaikov
reviewed
Jan 6, 2018
| @@ -330,4 +330,7 @@ | |||
| /* Defined if getentropy() is available */ | |||
| #cmakedefine HAVE_GETENTROPY | |||
|
|
|||
| /* Defined if boost::context is available */ | |||
| #cmakedefine HAVE_BOOST_CONTEXT | |||
There was a problem hiding this comment.
is this macro used anywhere? or i am just missing something.
There was a problem hiding this comment.
sorry, nvm. i found it at https://github.com/ceph/ceph/pull/19054/files#diff-b5fd6691c22ab2c09a283b8bdda0e9ecR22
tchaikov
approved these changes
Jan 6, 2018
|
@cbodley Mainly due to the fact that Boost 1.66 has not made it in the current set of packages. So I've build my own packages for Boost and matching Cmake. But it doable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes compilation failures in radosgw with boost 1.66, and pins that as the required version so we don't have to continue supporting beast as a submodule
Fixes: http://tracker.ceph.com/issues/22600